SmartIR icon indicating copy to clipboard operation
SmartIR copied to clipboard

Adding support for imperial units

Open devbyaccident opened this issue 1 year ago • 9 comments

From https://github.com/smartHomeHub/SmartIR/pull/795, which was closed without review.

This adds support for Fahrenheit handling to the climate entity, so now the current temperature from the temperature sensor will properly match the target temperature within the climate display in terms of units.

Closes https://github.com/smartHomeHub/SmartIR/issues/1042

devbyaccident avatar Aug 02 '23 18:08 devbyaccident

I copied this into my own HA instance and it works great. I hope this PR can get some attention from the maintainer(s)!

jrunning avatar Aug 04 '23 20:08 jrunning

+1 for it working on my own instance

TheAppleFreak avatar Aug 05 '23 05:08 TheAppleFreak

Tested in my instance of HA as well.

Thanks @devbyaccident!

seajhawk avatar Aug 05 '23 13:08 seajhawk

Thanks for this, works for me.

Noticed there was an update recently to the component, so I figured it's worth bumping this again to maybe get it looked at again.

TheAppleFreak avatar Oct 02 '23 17:10 TheAppleFreak

Cherry-picked this change into my own fork and am running it on my HA install. It seems to work fine so far. Would be nice to see this get merged.

ardichoke avatar Oct 15 '23 17:10 ardichoke

This works for me, thank you 👍

dylan-travis avatar Apr 11 '24 18:04 dylan-travis

Regarding that last merge, there's one additional change that needs to be made due to changes in HA Core since this PR was written: TEMP_FAHRENHEIT needs to be changed to UnitOfTemperature.FAHRENHEIT instead, otherwise it'll spit out deprecation notices in the HA logs.

TheAppleFreak avatar May 31 '24 14:05 TheAppleFreak

Regarding that last merge, there's one additional change that needs to be made due to changes in HA Core since this PR was written: TEMP_FAHRENHEIT needs to be changed to UnitOfTemperature.FAHRENHEIT instead, otherwise it'll spit out deprecation notices in the HA logs.

Good callout. I'm not sure when I'll get a chance to work on this, day job been keeping me pretty busy lately, but hopefully will be able to take a look before end of June.

devbyaccident avatar May 31 '24 14:05 devbyaccident