SmartIR
SmartIR copied to clipboard
smartHomeHub
Adding support for imperial units... again
It looks like there have been several issues raised for this already, (https://github.com/smartHomeHub/SmartIR/issues/29, https://github.com/smartHomeHub/SmartIR/issues/155, https://github.com/smartHomeHub/SmartIR/issues/160, https://github.com/smartHomeHub/SmartIR/issues/669, and https://github.com/smartHomeHub/SmartIR/issues/686) and a couple of pull requests that got closed without being merged (https://github.com/smartHomeHub/SmartIR/pull/692, https://github.com/smartHomeHub/SmartIR/pull/795) but SmartIR still doesn't have support for imperial units/Fahrenheit.
Can one of the maintainers please add this feature? Or at least turn off stalebot while it's being worked on?
I have no idea... FWIW, I copied the contents from climate.py in https://github.com/smartHomeHub/SmartIR/pull/795 to my HA config, (Props to @kevin-brown, that was some solid work) and it works fine for me. Haven't put it in a branch or anything, but a forked copy would work fine.
Edit: Typo
We just had 48d7f1f 2 weeks ago, @vassilis-panos clearly has the power to merge things. So I'm not sure why #795 has been ignored.
Would love to get this implemented.
Yep, I got bit by this too. It actually makes it impossible to control devices using Apple Home, as the gauge to control the temperature starts well above the max temperature in my device's codes with this incorrect conversion.
Screenshot of the Apple Home app
Ok, I just put in a PR for it, hope you don't mind co-author @kevin-brown, but this is long overdue.
LMK if causes issues and I'll close
We've had 3 releases since #795 and 2 since #1103, with absolutely no progress or comment on why these are being ignored.
@vassilis-panos, can we get some response as to what's going on here?
If someone forks, renames, and has/keeps imperial support a priority, I think that would likely be the most probable outcome.
On Thu, Dec 14, 2023, 4:20 PM Taylor C Jensen @.***> wrote:
We've had 3 releases since #795 https://github.com/smartHomeHub/SmartIR/pull/795 and 2 since #1103 https://github.com/smartHomeHub/SmartIR/pull/1103, with absolutely no progress or comment on why these are being ignored.
@vassilis-panos https://github.com/vassilis-panos, can we get some response as to what's going on here?
— Reply to this email directly, view it on GitHub https://github.com/smartHomeHub/SmartIR/issues/1042#issuecomment-1857068965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABJ4YDDHXGAAZ3HHANPYDYJOJVLAVCNFSM6AAAAAAXK3EXZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJXGA3DQOJWGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>
It's just such a silly thing to fork over. There's no need to duplicate effort in other places to support the rest of the project in Fahrenheit. The entire change is 15 lines of code, it can and should easily coexist here.
It's just such a silly thing to fork over. There's no need to duplicate effort in other places to support the rest of the project in Fahrenheit. The entire change is 15 lines of code, it can and should easily coexist here.
Sure, if you don't mind not being able to update SmartIR without manually altering climate.py each time (and also hoping the above diff doesn't get outdated...)
It'd be nice if the maintainer of this project could weigh in re: why this isn't getting merged. If it's a bad idea, it could be reworked or definitively say that imperial support is out of scope for this project.
Since there appears to be no feedback, all we can do is guess why these patches just sit there.
