client-py icon indicating copy to clipboard operation
client-py copied to clipboard

Published 20 hours ago • verified publisher icon smart-on-fhir

Reauthorization does not work beyond the first attempt

Open timharsch opened this issue 3 years ago • 4 comments

When using this library to download a large number of documents/resources from Cerner sandbox, it became apparent that reauthorization fails for all but the first attempt. This is because the refresh_token is lost when process the response from the remote host. In Cerner's case, it does not return the refresh token in the response, and so the token is erased from the server instance referenced by client.server

In our case we only use the DSTU2 version of client-py and I don't see anything in the CONTRIBUTING.md document about how to target PRs, so I'll just leave my solution here (which is a commit added on top on the v1.0.6 tag) https://github.com/Unite-Genomics/client-py/commit/c4f02e92a255ed09e2711f80e3b1d0ddd525589a

timharsch avatar Jan 03 '22 19:01 timharsch

Hi @timharsch, pull requests are welcome, let me know if still interested

ducu avatar Aug 27 '22 13:08 ducu

PR created

timharsch avatar Sep 12 '22 23:09 timharsch

Will be opening a new PR soon that applies the fix to the master branch.

timharsch avatar Sep 14 '22 18:09 timharsch

Hi @ducu , the new PR is ready. Can you merge please?

timharsch avatar Sep 21 '22 19:09 timharsch