Stefan Marr

Results 117 comments of Stefan Marr

This PR is out of date. A new one may be opened based on the current branch derived from Carmen's version, which is based on Clement's code: https://github.com/smarr/SOMns/tree/ct/async-stack-traces

Can't reproduce with latest `master`. Might that be something that got broken in a branch?

While https://github.com/smarr/SOMns/pull/164 changes some things around this issue, I don't think it actually fixes it. But, I still have no clue how it can happen.

Another related test failure, I think: ``` java.lang.StackOverflowError at som.interpreter.nodes.dispatch.CachedSlotRead$UnwrittenSlotRead.(CachedSlotRead.java:83) at som.interpreter.objectstorage.StorageLocation$UnwrittenStorageLocation.getReadNode(StorageLocation.java:112) at som.compiler.MixinDefinition$SlotDefinition.createNode(MixinDefinition.java:568) at som.compiler.MixinDefinition$ClassSlotDefinition.createNode(MixinDefinition.java:642) at som.compiler.MixinDefinition$SlotDefinition.getDispatchNode(MixinDefinition.java:535) at som.interpreter.nodes.dispatch.UninitializedDispatchNode$AbstractUninitialized.createSomDispatchNode(UninitializedDispatchNode.java:101) at som.interpreter.nodes.dispatch.UninitializedDispatchNode$AbstractUninitialized.insertSpecialization(UninitializedDispatchNode.java:73) at som.interpreter.nodes.dispatch.UninitializedDispatchNode$AbstractUninitialized.specialize(UninitializedDispatchNode.java:59) at som.interpreter.nodes.dispatch.UninitializedDispatchNode$AbstractUninitialized.specialize(UninitializedDispatchNode.java:174) at som.interpreter.nodes.dispatch.UninitializedDispatchNode$AbstractUninitialized.executeDispatch(UninitializedDispatchNode.java:134) at som.interpreter.nodes.dispatch.CachedSlotRead.executeDispatch(CachedSlotRead.java:53)...

Ok, so I might have a clue what this is about. Currently, we invalidate an object layout, and then construct a new one. At least in our parallel `BasicInterpreterTests`, this...

PR #244 also solve an issue with not handling invalid layouts in the `ClassSlotAccessNode`. This could cause data been written to the wrong memory address, I think. It is hard...

There is another issue lurking: https://travis-ci.org/smarr/SOMns/jobs/379663247#L4988 ``` BenchmarkHarnessTests Total Number of Tests: 2 Number of Successful Tests: 2 ActorTests instance of FarReference Uncaught exception on ActorProcessingThread-0 Processing failed for: Actor...

And another one: https://travis-ci.org/smarr/SOMns/jobs/423684181#L1239 ``` java.lang.AssertionError: null is not a valid value for an object slot, it needs to be initialized with nil. at som.interpreter.objectstorage.StorageLocation$ObjectStorageLocation.isSet(StorageLocation.java:210) at som.compiler.MixinDefinition$SlotDefinition.getDispatchNode(MixinDefinition.java:571) at som.interpreter.nodes.dispatch.UninitializedDispatchNode$AbstractUninitialized.createSomDispatchNode(UninitializedDispatchNode.java:98) at...

Yes, it shouldn't. Seems like a simple getting-started issue, would keep it open, except if it annoys you.

Hi @CortezDeuce: Sure, if you want to dig in, you might want to start having a look at http://somns.readthedocs.io/en/dev/ It describes some basic steps on how to setup things. I'd...