ReBench icon indicating copy to clipboard operation
ReBench copied to clipboard

Evaluate using `Popen(shell=False, ...)`

Open smarr opened this issue 1 year ago • 1 comments

Should we avoid using the shell for running commands?

Think this is a major change at the core of ReBench. So, we'd probably need to carefully test this. See https://github.com/smarr/ReBench/pull/248#issuecomment-2269272256

smarr avatar Aug 20 '24 14:08 smarr

At the moment, we request explicitly the use of a shell here: https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L532

However, we run build commands without shell here: https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L397

smarr avatar Aug 20 '24 14:08 smarr