marge-bot icon indicating copy to clipboard operation
marge-bot copied to clipboard

Fix guarantee final pipeline

Open qusielle opened this issue 3 years ago • 6 comments

Background: There are cases when a project needs to have a final run of the CI pipeline before the merge. For example, if a team practices fixup-driven code review process in a project, the fixup commits must be auto-squashed prior to a merge. This can be done in CI check by having a job that performs the check only when Marge-bot is assigned. Gitlab CI is not triggered automatically on actions like assigning, so that Marge-bot --guarantee-final-pipeline option is what is exactly needed in this case: it is supposed to trigger a pipeline right before the merge.

Problem and cause: --guarantee-final-pipeline does not trigger Gitlab CI at all. Only a comment jenkins retry appears in the review. Looking to the code, it is visible that no more than additional 30 seconds of waiting is implemented.

Measure:

  • When --guarantee-final-pipeline is specified, change the Marge-bot behavior to triggering a merge request pipeline (falling back to a regular branch pipeline if MR workflow is not set up) and waiting for it to pass.
  • Check the solution in Marge-bot tests.

qusielle avatar Sep 30 '22 19:09 qusielle

@qusielle @d3m3vilurr ping. This feature would be very interesting to us as well but my company only accepts tagged/released versions. Would be great to have this feature merged soon :)

felh avatar Apr 13 '23 13:04 felh

@qusielle @d3m3vilurr ping. This feature would be very interesting to us as well but my company only accepts tagged/released versions. Would be great to have this feature merged soon :)

Hello @felh, I would be happy to get this merged but I am afraid the repo is abandoned by its maintainers, as there are more people with active PRs and no response.

qusielle avatar Apr 15 '23 19:04 qusielle

@qusielle @d3m3vilurr ping. This feature would be very interesting to us as well but my company only accepts tagged/released versions. Would be great to have this feature merged soon :)

Hello @felh, I would be happy to get this merged but I am afraid the repo is abandoned by its maintainers, as there are more people with active PRs and no response.

There are a group of people who have recently forked the project at https://gitlab.com/marge-org/marge-bot

JohnVillalovos avatar Apr 15 '23 22:04 JohnVillalovos

@qusielle @d3m3vilurr ping. This feature would be very interesting to us as well but my company only accepts tagged/released versions. Would be great to have this feature merged soon :)

Hello @felh, I would be happy to get this merged but I am afraid the repo is abandoned by its maintainers, as there are more people with active PRs and no response.

There are a group of people who have recently forked the project at https://gitlab.com/marge-org/marge-bot

Hey folks, as John said, this pull request has been imported into the community fork:

https://gitlab.com/marge-org/marge-bot/-/merge_requests/351

If you'd like to see it merged, please join over there. @qusielle do you have a GitLab.com account?

nejch avatar Apr 16 '23 09:04 nejch

Great to hear it was forked into something maintainable!

If you'd like to see it merged, please join over there. @qusielle do you have a GitLab.com account?

@nejch, yes, I do. It is the same name there. I will get into it a bit later this week.

qusielle avatar Apr 17 '23 22:04 qusielle

@qusielle @d3m3vilurr ping. This feature would be very interesting to us as well but my company only accepts tagged/released versions. Would be great to have this feature merged soon :)

Hello @felh, I would be happy to get this merged but I am afraid the repo is abandoned by its maintainers, as there are more people with active PRs and no response.

There are a group of people who have recently forked the project at https://gitlab.com/marge-org/marge-bot

Hey folks, as John said, this pull request has been imported into the community fork:

https://gitlab.com/marge-org/marge-bot/-/merge_requests/351

If you'd like to see it merged, please join over there. @qusielle do you have a GitLab.com account?

couple weeks ago, I also got a email from gitlab.org about import an issue. I'm glad to see a maintainable fork :)

now I've reopened a thread of my comment in gitlab, and copied thread comments of this to there.

d3m3vilurr avatar Apr 20 '23 09:04 d3m3vilurr