marge-bot icon indicating copy to clipboard operation
marge-bot copied to clipboard

Some code quality ideas

Open arvidj opened this issue 4 years ago • 3 comments

I'm wondering what your general feeling would be about:

  • Using poetry for dependency management for those not using nix.
  • Using a code formatter like black.
  • Using typehints and typechecker like mypy. I've experimented using pyannotate to annotate tests/gitlab_api_mock.py (it required a fair deal of manual annotation though) and found the resulting file far easier to understand.

arvidj avatar Nov 03 '21 19:11 arvidj

#291 Has some poetry work going on there.

JohnVillalovos avatar Jan 04 '22 21:01 JohnVillalovos

FYI, black is now stable , and is used by e.g. Drupal.

arvidj avatar Feb 10 '22 13:02 arvidj

I guess all of this is also related to https://github.com/smarkets/marge-bot/issues/295, as there's more quality of life stuff for developers discussed there, but there's a bit of a backlog already.

nejch avatar Feb 10 '22 17:02 nejch