marge-bot icon indicating copy to clipboard operation
marge-bot copied to clipboard

reviewers stripped on gitlab CE

Open anholt opened this issue 5 years ago • 2 comments

freedesktop.org uses gitlab CE, so we can't use the approvals feature. However, the release has --add-reviewers by default which seems to strip off Reviewed-by tags that were already in the commit. Any chance you could detect that approvals aren't supported on the gitlab instance and avoid stripping that tag out of our commits?

anholt avatar Dec 13 '19 23:12 anholt

I think I've got this worked around with dropping --add-reviewers from the deploy.yml.

anholt avatar Dec 14 '19 00:12 anholt

Might be unrelated but I recall that specific feature was requiring gitlab admin privileges to function.

alatiera avatar Dec 14 '19 21:12 alatiera