marge-bot icon indicating copy to clipboard operation
marge-bot copied to clipboard
verified publisher icon smarkets

Better handling of missing approvals after rebase when not asked to reapprove

Open jcpetruzza opened this issue 8 years ago • 1 comments

If the merge request has approvals and marge is not asked to reapprove, then after a rebase she won't be able to merge and will get confused / report the wrong error.

The right logic is to: refetch approvals immediately after the rebase, if there are missing approvals and was asked to reapprove, then reapprove, otherwise, fail with a proper error.

jcpetruzza avatar Jul 01 '17 15:07 jcpetruzza

Any update on this? Ist marge-bot still maintained?

dgroh avatar Jul 01 '22 08:07 dgroh