python-pytest-harvest
python-pytest-harvest copied to clipboard
MAINT: Updates for pytest 8.1 and python 3.12
Supersedes #65
Modernizes some stuff:
- Updates for Pytest 8.1
- ~~Use
packagingto get module versions rather thandistutils(which is gone in 3.12)~~ - Set Python min to 3.8 (3.7 is EOL)
- Set pytest min to 6 (almost 4 years old)
- Remove
sixbecause with 3.8 min we can - Test on CI and adapt to 3.12
If it's not desired to drop python_version < 3.8 I can get rid of all that stuff and restore tests etc. This just seemed like the cleanest / most maintainable way forward to me!
... and pytest 6 came out June 2020, so almost 4 years ago. I think it's okay to require that as a minimum as well. (Anyone on an ancient version of pytest can stick with an older version of pytest-harvest, no?)
This is now hitting https://github.com/smarie/python-pytest-cases/issues/330 I think (found from https://github.com/pytest-dev/pytest/issues/11868#issuecomment-1913630682) but otherwise is in good shape I think! So for now I'll get rid of the -latest case.
Great stuff @larsoner ! Thanks so much for spending time to work on this.
I'll switch the backend to vitualenv first, so I'll start from this PR https://github.com/smarie/python-pytest-harvest/pull/70
Then I'll merge interesting stuff from your branch in. Hopefully this will happen in the upcoming days, I'll keep you posted
I merged the PR to release a first version 1.10.5 with some of your fixes and others.
I am now totally in favour of moving forward with your proposals (python 3.8 and pytest 6). Could you just update this PR to the latest, I'll have a look afterwards. No particular hurry of course.
@smarie looks like the conflicts are bad, feel free to take over in a new PR if you want!