python-makefun icon indicating copy to clipboard operation
python-makefun copied to clipboard

Match type exactly when checking TYPES_WITH_SAFE_REPR

Open moskupols opened this issue 1 year ago • 2 comments

This fixes #98

My understanding is that here we are trying to say whether a builtin literal for str, int, bytes, or bool would produce the same value as given. However, that is only possible if the given value has one of these types.

moskupols avatar Jan 25 '24 20:01 moskupols

Hi @moskupols thanks for this Proposal ! Indeed it makes sense. Could you please update your branch to the latest ? I just switched the nox backend to virtualenv for convenience. Note that you'll need "nox==2022.11.21" and "virtualenv==16" to be able to create all nox sessions including those for python 2.7, 3.5 3.6 and 3.7.

smarie avatar Mar 12 '24 17:03 smarie

Hi @smarie ! I've just merged main and updated the test so that it runs on earlier versions of python as well.

moskupols avatar Mar 19 '24 00:03 moskupols

Hi @smarie ! Is there a chance to merge the PR?

moskupols avatar Jun 26 '24 17:06 moskupols

Thanks @moskupols and sorry for the delay !

smarie avatar Jul 02 '24 21:07 smarie

@smarie do you have an approximation when next version wiil be released?

AlexeyDmitriev avatar Jul 03 '24 12:07 AlexeyDmitriev

Hi @AlexeyDmitriev and @moskupols , thanks for your feedback ! I was expecting to release it just after merging yesterday, but unfortunately there is an issue in my build system (#105 ). I'll try to find 15' to fix this by the end of the week, hopefully it is just a matter of getting rid of nox_utils.py and using the proper nox.parametrize routines, now that they are available.

smarie avatar Jul 03 '24 14:07 smarie

1.15.3 is now released

smarie avatar Jul 05 '24 10:07 smarie