Sylvain Marié comments

Results 299 comments of


                                            Sylvain Marié

Attempt to fix issue #43

(replying to https://github.com/smarie/python-autoclass/pull/44#discussion_r697876595 ) Perfect @erocarrera thanks for the feedback ! Indeed moving to pyfields when possible is probably a better choice. I did not yet found time to fix...

Validate after setting multiple fields at once

This is a great suggestion ! It seems to connect with similar ideas/suggestions #8 and #25 I do not remember if I already wrote something in the code to prepare...

Validate after setting multiple fields at once

Thanks @jgarbers for your feedback ! Your message does not really seem to relate to this issue #72 - @bharathbhushan1 meant validation that can not be performed field by field...

Separate makers for hash, dict, eq, and repr

This would be a great addition @pfw , thanks for suggesting it ! Would you like to propose such mod yourself in a PR ? I think the code change...

Separate makers for hash, dict, eq, and repr

Great thanks for the feedback @pfw ! For the implementation, the only tricky thing is that you'll see that `make_init` returns a class descriptor (`InitDescriptor`) for the method, that is...

Feature request: Option for keyword-only constructor in `make_init` and friends

This is a nice suggestion @burnpanck ! It could even be made the default, as it makes sense. Would you like to give a shot at a PR ? Otherwise...

Feature request: Option for keyword-only constructor in `make_init` and friends

Ok, thanks for the feedback ! Let me know.

Capability to register listeners (observers) on read and write

thanks for the advice ! I did not yet know `trio`, I'll have a look

`make_init` should contain a call to super() in generated init body

Not sure this is actually good. I see more cons than pros. Let's wait a little bit for feedback.

tests fail with python 3.12

Thanks @keszybz ! I'll investigate when I find a bit of time.