Sylvain Marié comments

Results 299 comments of


                                            Sylvain Marié

Use `signature` and set `wrapped` attribute even on signature-changing decorators.

Thanks @lucaswiman ! Sorry to be picky, but I just realized one important thing (see comment in code). Also could you please include in the PR an update to the...

Improve `add_signature_parameters` : add `first_possible` and `last_possible`

> On second thought, I am rethinking my position. Explicit is better than implicit after all. Yes this is basically what I had in mind: users thinking that `first` is...

Improve `add_signature_parameters` : add `first_possible` and `last_possible`

> Do the positional ones go at the end of the list of positional parameters, while the keyword ones go at the end of the kwargs list? Should these work...

Improve `add_signature_parameters` : add `first_possible` and `last_possible`

Thanks to both of you ! To be honest I think that it would be a little sad not to solve the original issue here. It seems to me that...

Forward references in annotations with a signature changing decorator

good catch @lucaswiman !

Forward references in annotations with a signature changing decorator

@lucaswiman : does this bug also happen if you use `create_function` (but not `wraps`) ? It is indeed key to decide if we should perform the change only for `wraps`...

Forward references in annotations with a signature changing decorator

Thanks again @lucaswiman ! Note: I eventually modified your contribution to perform `get_signature_from_string` inside `wraps`, for consistency. That way, `create_function` does not try to be intelligent about the `__signature__` attribute,...

Fix typo for note

good catch @jeaubin ! thanks

Fix typo for note

(Un)fortunately this uncovered a bug from makefun : https://github.com/smarie/python-makefun/issues/89 Thanks x2 then !

What's the difference between local variable, cell variable and free variable?

Great post ! One thing seems to be missing though: `co_names` is not explained. See https://github.com/python/cpython/pull/2743 (where I see @laike9m contributes already :) )