girlscript_app icon indicating copy to clipboard operation
girlscript_app copied to clipboard

Published 20 hours ago • verified publisher icon smaranjitghose

LinkedIn Authentication

Open himanshusharma89 opened this issue 5 years ago • 20 comments

himanshusharma89 avatar Oct 01 '20 07:10 himanshusharma89

I can do this by this package

SirusCodes avatar Oct 02 '20 13:10 SirusCodes

Okay, @SirusCodes go ahead. Assigning it to you.

himanshusharma89 avatar Oct 02 '20 14:10 himanshusharma89

Yup Thanks👍

SirusCodes avatar Oct 02 '20 14:10 SirusCodes

@himanshusharma89 can you give me client id and client secret? You can send me a mail or message me any social media

SirusCodes avatar Oct 02 '20 17:10 SirusCodes

@SirusCodes you can create an example app yourself and try it, I'll change it after merging it

himanshusharma89 avatar Oct 03 '20 01:10 himanshusharma89

Can you give me your android debug key or will you add mine to the project? I also need to use custom token as firebase doesn't support LinkedIn login natively Also please do the required in firebase as in the link above

SirusCodes avatar Oct 03 '20 05:10 SirusCodes

@SirusCodes share me your gmail, I'll add you to the project in the console.

himanshusharma89 avatar Oct 03 '20 06:10 himanshusharma89

[email protected]

SirusCodes avatar Oct 03 '20 06:10 SirusCodes

@SirusCodes I have added you to the console, you can work on it now.

himanshusharma89 avatar Oct 03 '20 09:10 himanshusharma89

I got the notification I would start working on it soon...

SirusCodes avatar Oct 03 '20 09:10 SirusCodes

Hey @himanshusharma89 I made changes in the application, but linkedin have a review process to allow sign in with linkedin. I don't think that my request would be accepted. So should I make a PR now or something else?

SirusCodes avatar Oct 03 '20 11:10 SirusCodes

@SirusCodes Create a PR from a different branch, I'll label it to be eligible for Hacktoberfest

himanshusharma89 avatar Oct 03 '20 12:10 himanshusharma89

@himanshusharma89 why #285 is not counted as eligible PR for hacktoberfest?

SirusCodes avatar Oct 03 '20 15:10 SirusCodes

@SirusCodes Hacktoberfst added new rules against spamming, I'll add a label and it'll be counted. Check this: https://hacktoberfest.digitalocean.com/hacktoberfest-update

himanshusharma89 avatar Oct 03 '20 15:10 himanshusharma89

@SirusCodes Check it now

himanshusharma89 avatar Oct 03 '20 15:10 himanshusharma89

@himanshusharma89 Not yet...maybe it will take some time I guess...thanks😃

SirusCodes avatar Oct 03 '20 15:10 SirusCodes

Is this still active? I would like to work on this

umang-sinha avatar Oct 04 '21 16:10 umang-sinha

Sure @umang-sinha, assigning it to you.

himanshusharma89 avatar Oct 04 '21 18:10 himanshusharma89

I am sure @SirusCodes has eyes on some other projects 😆

himanshusharma89 avatar Oct 04 '21 18:10 himanshusharma89

@himanshusharma89 The issue should be closed by now as the code was complete, @umang-sinha maybe can fix deprecated APIs if any😅

@umang-sinha I would suggest you to continue with this PR.

SirusCodes avatar Oct 04 '21 18:10 SirusCodes