bootstrap-datetimepicker icon indicating copy to clipboard operation
bootstrap-datetimepicker copied to clipboard

top

Open hezedu opened this issue 11 years ago • 17 comments

506 line : top=top+document.body.scrollTop is a bug.

delete it

hezedu avatar Mar 17 '15 06:03 hezedu

I have found the same bug today. Is this project still alive?

lvshin avatar Jul 24 '15 07:07 lvshin

Describe why it is a bug. What behaviour can you observe?

AuspeXeu avatar Aug 20 '15 09:08 AuspeXeu

You can see this bug on a mobile device...see attached file... bug_datetimepicker

Aleksandern avatar Sep 17 '15 09:09 Aleksandern

Which device/browser and do you have the link to the website for me?

AuspeXeu avatar Sep 17 '15 09:09 AuspeXeu

Android Opera... You can also use Chrome DevTools device mode (https://developers.google.com/web/tools/setup/device-testing/devtools-emulator), just select Google Nexus 5... Your demo pages doesn't have this bug...

Unfortunately I can't provide a link. However, I can create a new page if you can't catch this bug.

Aleksandern avatar Sep 17 '15 09:09 Aleksandern

Well that's hard to grasp then if I cannot reproduce :D

AuspeXeu avatar Sep 17 '15 09:09 AuspeXeu

Ok. Give me some time please

Aleksandern avatar Sep 17 '15 09:09 Aleksandern

Sure thing :+1:

AuspeXeu avatar Sep 17 '15 09:09 AuspeXeu

scroll to bottom of the page... after that click "Start date" or "End date"

http://.../pages/index.html

Aleksandern avatar Sep 17 '15 15:09 Aleksandern

Okay. This seems to be buggy in Chrome but works perfectly fine in firefox. Can you patch the website so that it works in chrome by using this comment? 506 line : top=top+document.body.scrollTop

AuspeXeu avatar Sep 17 '15 15:09 AuspeXeu

I've commented 537 line

if( !elementOrParentIsFixed(this.element) ){ //top = top + document.body.scrollTop; }

Aleksandern avatar Sep 17 '15 15:09 Aleksandern

And then it seems to work on mobile + chrome + firefox. Can you confirm that?

AuspeXeu avatar Sep 17 '15 15:09 AuspeXeu

Yes I confirm that.

Aleksandern avatar Sep 17 '15 15:09 Aleksandern

Mind filing a pull request for this fix?

AuspeXeu avatar Sep 17 '15 18:09 AuspeXeu

You mean I need to create a pull request?

Aleksandern avatar Sep 18 '15 02:09 Aleksandern

Yes please

AuspeXeu avatar Sep 18 '15 06:09 AuspeXeu

Will be resolved in PR #645, see commit edadb5b47db534e14b498de80978011d4fc5d7df

jarstelfox avatar Aug 23 '17 23:08 jarstelfox