cli icon indicating copy to clipboard operation
cli copied to clipboard

Also provide units to renew ssh certificates

Open darix opened this issue 3 years ago • 3 comments

Those are based on the cert-renewer unit files but adapted for ssh certificates

the target file allows you to easily stop/restart/disable all instances.

darix avatar Mar 24 '22 18:03 darix

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 24 '22 18:03 CLAassistant

@tashian Can you take a look to this?

maraino avatar Mar 24 '22 18:03 maraino

Hi @darix, this is ready to merge. Could you please sign our CLA so we can accept this PR?

Thank you for your contribution to the project. :D

tashian avatar Jul 26 '22 21:07 tashian

@darix Although contributions to an Apache 2 software might not require a CLA, see this blog post. We can merge this right away if you sign it, so we don't need to look into other implications, although in this case, I don't see any. So can you sign it?

@tashian is this still ok? Is there any update you can do to our current scripts that will avoid the need of merging this?

maraino avatar Aug 16 '22 01:08 maraino

sorry for the delay. signed now.

darix avatar Aug 23 '22 14:08 darix

I just noticed that this merge request was modified before the merge. I would like to understand the reasoning to only want to support ed25519 keys.

darix avatar Aug 26 '22 22:08 darix

@tashian any reason for hardcoding ed25519 key?

-            CERT_LOCATION=/etc/ssh/ssh_host_%i_key-cert.pub \
-            KEY_LOCATION=/etc/ssh/ssh_host_%i_key
+            CERT_LOCATION=/etc/ssh/ssh_host_ed25519_key-cert.pub \
+            KEY_LOCATION=/etc/ssh/ssh_host_ed25519_key

and pardon my ignorance, how is %i populated?

maraino avatar Aug 26 '22 23:08 maraino

if you have a service like [email protected] you can start the service with systemctl start foo@bar

then %i has the value bar.

long version here: https://0pointer.de/blog/projects/instances.html

darix avatar Aug 27 '22 00:08 darix

@darix sure, here's the reasoning for my hard coding of the Ed25519 key:

https://github.com/smallstep/cli/pull/657#discussion_r836879508

In short, I don't feel it's worth the added complexity of a systemd template to cover more than one host key type.

tashian avatar Aug 29 '22 19:08 tashian