smallrye-reactive-messaging icon indicating copy to clipboard operation
smallrye-reactive-messaging copied to clipboard

Kafka Companion: always pass the failure to the AssertionError

Open loicmathieu opened this issue 3 years ago • 1 comments

RecordsSubscriber did not pass the original throwable to the AssertionError in all cases so debugging a failure (like a mis-configuration) is hard (we need to use a debugger).

This PR takes care of transfering the failures each time we create an AssertionError from a failure. Not that in this case we may choose to throw the failure instead to make the test in error and not in failure.

loicmathieu avatar Aug 10 '22 12:08 loicmathieu

Codecov Report

Merging #1844 (44ca9ed) into main (bc3f407) will decrease coverage by 61.35%. The diff coverage is 0.00%.

:exclamation: Current head 44ca9ed differs from pull request most recent head e28e500. Consider uploading reports for the commit e28e500 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##               main    #1844       +/-   ##
=============================================
- Coverage     73.79%   12.44%   -61.36%     
+ Complexity     3150      438     -2712     
=============================================
  Files           276      276               
  Lines         11255    11262        +7     
  Branches       1438     1439        +1     
=============================================
- Hits           8306     1401     -6905     
- Misses         2263     9673     +7410     
+ Partials        686      188      -498     
Impacted Files Coverage Δ
...e/messaging/kafka/companion/RecordsSubscriber.java 25.39% <0.00%> (-33.40%) :arrow_down:
...allrye/reactive/messaging/health/HealthReport.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ipse/microprofile/reactive/messaging/Metadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...tive/messaging/ce/impl/BaseCloudEventMetadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...messaging/ce/DefaultCloudEventMetadataBuilder.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ssaging/tck/SmallRyeReactiveMessagingExtender.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ing/ce/impl/DefaultIncomingCloudEventMetadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ing/ce/impl/DefaultOutgoingCloudEventMetadata.java 0.00% <0.00%> (-100.00%) :arrow_down:
...smallrye/reactive/messaging/jms/JmsProperties.java 0.00% <0.00%> (-100.00%) :arrow_down:
...smallrye/reactive/messaging/mqtt/MqttFailStop.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 216 more

codecov-commenter avatar Aug 10 '22 13:08 codecov-commenter