smallrye-mutiny icon indicating copy to clipboard operation
smallrye-mutiny copied to clipboard

MultiOverflowStrategy.buffer() no-arg method leads to usage of a fixed-size buffer despite Javadoc unbounded claim

Open Ultranium opened this issue 2 years ago • 2 comments

Context

Mutiny v1.7.0

Description

The no-arg method MultiOverflowStrategy.buffer() calls the MultiOverflowStrategy.buffer(int) overload with the arg value of 128. This leads to usage of a fixed-size buffer despite the Javadoc of the buffer() method unbounded claim.

So, I guess, either the method implementation or the Javadoc itself should be changed.

Ultranium avatar Sep 07 '22 14:09 Ultranium

Thanks, we're having a look soon

jponge avatar Sep 07 '22 16:09 jponge

Yes, some things are wrong (plural):

  1. the javadoc is wrong, it should not mention unbounded, as it's clearly bounded.
  2. the magic value should be configurable from the Infrastructure class
  3. the creation of an unbounded variant should be possible

cescoffier avatar Sep 07 '22 16:09 cescoffier