smallrye-graphql icon indicating copy to clipboard operation
smallrye-graphql copied to clipboard

Don't use supplyAsync without an executor

Open phillip-kruger opened this issue 5 years ago • 1 comments
trafficstars

As mentioned by @cescoffier - in server/implementation/src/main/java/io/smallrye/graphql/spi/DataFetcherService.java

"Don't use supplyAsync without an executor. It picks a thread from the fork/join pool, you don't have any control."

That sounds like we might need some sort of config mechanism for users to be able to specify the executor service they want to use.

phillip-kruger avatar Oct 30 '20 09:10 phillip-kruger

I'm not sure it's a user setting. What about an infrastructure setting. For example in Quarkus, use the quarkus worker pool.

cescoffier avatar Oct 30 '20 11:10 cescoffier