smallrye-graphql icon indicating copy to clipboard operation
smallrye-graphql copied to clipboard

#1423: add GraphQLResult and wrap successful result

Open t1 opened this issue 3 years ago • 1 comments

Also: rename Wrapper#isNotEmpty to Wrapper#isNonNull and fix some warnings

TODOs:

  • [ ] Map all declared exceptions to fields
    • [ ] In the schema
    • [ ] When executing
  • [ ] Consider @GraphQLResult annotations on an API class
  • [ ] Consider @GraphQLResult annotations on a package
  • [ ] Provide a config option to globally enable result-wrapping (and add to GraphQLResult javadoc)
  • [ ] Maybe consider ErrorCode annotation (but convert kebap to camel?)
  • [ ] Documentation

t1 avatar May 27 '22 13:05 t1

@phillip-kruger: I have several smaller problems that you might be able to help with.

  1. The main branch doesn't compile (GraphQLWSSubprotocolHandler and GraphQLTransportWSSubprotocolHandler)
  2. In the main branch, the ReferenceCreator causes a StackOverflow
  3. I've added a TCK test for result, but it fails because it doesn't find the order method, but the same request runs in the runner!

I could fix 1. and 2., but I don't understand how they got in there.

t1 avatar May 27 '22 13:05 t1