grails-events-push icon indicating copy to clipboard operation
grails-events-push copied to clipboard

Incompatible with grails 2.4

Open bdbull opened this issue 10 years ago • 4 comments

This is incompatible with grails 2.4 due to the CongurationHolder class being removed. See the "Static Holder Classes" section at http://grails.org/doc/2.4.0.M1/guide/upgradingFrom23.html.

bdbull avatar Jun 02 '14 14:06 bdbull

The grails documentation shows that code that use ConfigurationHolder class needs to be updated with "grails.util.Holders". (see: Static Holder Classes - http://grails.org/doc/2.4.x/guide/upgradingFrom23.html).

In that case the grails-events-push plugin also needs to be up-to-date. I believe that just by adding: "import grails.util.Holders" instead of "import org.codehaus.groovy.grails.commons.ConfigurationHolder" at "/events-push-1.0.M7/scripts/_Events.groovy" (line 20, column 1) would solve the problem.

tiagopomponet avatar Jun 02 '14 20:06 tiagopomponet

@tiagopomponet pull request welcomed!!

jfarcand avatar Jun 02 '14 21:06 jfarcand

Can someone push this to the grails plugin repository?

bdbull avatar Oct 31 '14 20:10 bdbull

Still waiting for the grails repo to be updated with this.

vtr88 avatar Nov 12 '14 18:11 vtr88