PlasFlow icon indicating copy to clipboard operation
PlasFlow copied to clipboard

New release: fix discrepancy between pypi, release, and git

Open bernt-matthias opened this issue 3 years ago • 2 comments

I'm currently trying to fix the bioconda recipe for plasflow: https://github.com/bioconda/bioconda-recipes/pull/27766

I noticed that the content of the download available at pypi and the release on github seems to differ. In particular the model dir seems missing in the pypi release.

I guess its because in setup.py

package_data={'models': ['models/*']},

should be

package_data={'plasflow': ['models/*']},

It would be great if you could create a new release fixing this.

bernt-matthias avatar Jun 03 '21 08:06 bernt-matthias

I reverted to the latest stable release. I hope it is fixed now.

Unfortunately, I moved to completely other field, thus my time for this project is seriously limited.

smaegol avatar Jun 28 '21 11:06 smaegol

I think that bioconda recipe cannot be fixed, as they clearly state that if this only works ith Py3.5 they cannot support it (https://github.com/bioconda/bioconda-recipes/blob/master/recipes/plasflow/meta.yaml#L22). As I mentioned, I reverted back to previous, stable, working release (the same as in pypi); I thought that more package-like structure proposed by @dcdanko will be better, but I haven't tested it thoroughly before merging pull request, my fault.

smaegol avatar Jun 28 '21 16:06 smaegol