libgit2.cr icon indicating copy to clipboard operation
libgit2.cr copied to clipboard

Is there a plan to make this project fully compatible with rugged?

Open zhuangbiaowei opened this issue 6 years ago • 4 comments

e.g.

repo.last_commit.oid return -> String

but,in this lib:

repo.last_commit.target_id.to_s return -> String

zhuangbiaowei avatar Jan 14 '19 00:01 zhuangbiaowei

The aim is to be as compatible as possible but most probably it will be impossible to archive 100% compatibility. Please also keep in mind that the project is at a very early stage right now.

smacker avatar Feb 13 '19 14:02 smacker

I am also working on this project recently. If you are interested, I hope to submit PR to you.

https://github.com/zhuangbiaowei/libgit2.cr

zhuangbiaowei avatar Feb 14 '19 01:02 zhuangbiaowei

@zhuangbiaowei Nice work!

Since you did quite a lot of changes, I'd suggest to make multiple small PR for each kind of changes you did. This way the reviewer (@smacker) does have too much code to review and you get better feedback on it.

bew avatar Mar 07 '19 13:03 bew

@bew Thank you for your suggestion.

I am willing to submit some smaller PRs. However, I am more worried about @smacker. It seems that his time is not very certain. In my comments, he will take a long time to reply...

zhuangbiaowei avatar Mar 13 '19 01:03 zhuangbiaowei