Maxim Sukharev
Maxim Sukharev
Confirm about push force. I checked logs again. This error happens very rarely. But all the errors I see were caused by push-force (I went manually to each PR and...
Tests are failing obviously.
As a solution, we can do in `ctxlog/context.go`: ```go var NewLogger = log.New ``` then we will be able to mock it in the tests. What do you think @carlosms...
Sadly we can not. LoggerFactory isn't an interface but a struct [defined in go-log](https://github.com/src-d/go-log/blob/master/default.go#L16). And there is [no way](https://github.com/src-d/go-log/blob/master/factory.go#L64) to replace logrus in `New` with something else. I'll proceed with...
If you return comment without file as it's described in [proto](https://github.com/src-d/lookout-sdk/blob/master/proto/lookout/sdk/service_analyzer.proto#L51) file, such comment will be posted as a normal regular comment. Does it solve your problem?
Another solution to this issue would be to export sdk version in go sdk, same as we do in python sdk: https://github.com/src-d/lookout-sdk/blob/master/python/lookout/sdk/__init__.py Then `lookout-tool` can just print it. @carlosms wdyt?
I suggest having only 1 variable somewhere in the sdk. And update python&go sdk to read it.
I have tried a few solutions for having it only in one place and I don't like the result at all. Let's pause this issue for now as we are...
Currently go-git [doesn't support](https://github.com/src-d/go-git/issues/599) short hashes.
because it's convenient to support short sha1s. ``` git log --oneline /find commit from which we want to test base revision '9c3b4a2' error: reference not found ```