ffsubsync icon indicating copy to clipboard operation
ffsubsync copied to clipboard

Provide Dockerfile / Docker image

Open PeterDaveHello opened this issue 4 years ago • 12 comments

Not sure if you'd like to provide Dockerfile / Docker image so that subsync can be easily used without environment setup? I can help contribute Dockerfile if you want 🙂 Or I'll host it on my own account.

PeterDaveHello avatar May 03 '20 08:05 PeterDaveHello

Oops, used a wrong label, looks like I don't have the permission to remove it.

PeterDaveHello avatar May 03 '20 08:05 PeterDaveHello

I am looking for a dockerfile or docker image :) Maybe @PeterDaveHello can provide me his dockerfile if you have one?

leonvsc avatar May 03 '20 10:05 leonvsc

Yeah, I'll be happy to help, just want to confirm that if we can make it official.

PeterDaveHello avatar May 03 '20 10:05 PeterDaveHello

Alright thanks. Do you have already a dockerfile? If yes, can you link it to me?

leonvsc avatar May 03 '20 10:05 leonvsc

@PeterDaveHello no worries and I would love to provide a Dockerfile. Would you be willing to submit a pull request? Would be delighted to have your contribution.

smacke avatar May 03 '20 14:05 smacke

Sure thing I'd like to do, currently I'm tuning and testing the image, give me few days to prepare it.

PeterDaveHello avatar May 03 '20 16:05 PeterDaveHello

@leonvsc try this image please:

peterdavehello/subsync:testing
docker.pkg.github.com/peterdavehellokitchen/dockerregistry/subsync:testing

https://hub.docker.com/r/peterdavehello/subsync https://github.com/PeterDaveHelloKitchen/DockerRegistry/packages/209353

Let me know if you got any issues

PeterDaveHello avatar May 06 '20 15:05 PeterDaveHello

Thanks for the image. I will have a look into it. Can you provide me some documentation on how to use it? Especially how to run commands from subsync?

My ultimate goal was to integrate it via a Docker mod on the linuxserver.io bazarr image. Bazarr has a postprocessing section where you can run commands when the subtitle is done downloading.

leonvsc avatar May 06 '20 15:05 leonvsc

Thanks for the image. I will have a look into it. Can you provide me some documentation on how to use it? Especially how to run commands from subsync?

You could try this, replace --version with the parameters of subsync you want to use:

docker run -it -v $PWD:/video --workdir /video peterdavehello/subsync:testing subsync --version

PeterDaveHello avatar May 06 '20 16:05 PeterDaveHello

Thanks for the documentation. I have tested it a little bit and i didnt ran into any issues. Maybe ask other people to test it also. I dont have a lot of free time atm.

leonvsc avatar May 07 '20 09:05 leonvsc

Please note that I've published the all images here: https://hub.docker.com/repository/docker/peterdavehello/subsync

Available tags: https://hub.docker.com/r/peterdavehello/subsync/tags

PeterDaveHello avatar May 19 '20 06:05 PeterDaveHello

Will this Docker image contain an old version of FFsubsync as it was a while ago it was created? @PeterDaveHello can you provide with the Dockerfile you applied so one can create a new image that is up to date?

Klench avatar Sep 18 '23 18:09 Klench