Lukas Märdian

Results 56 comments of Lukas Märdian

I'm interested in this fix. It sounds like it could fix the spread test issue we're seeing in Netplan's CI: ``` Run ~/go/bin/spread -v lxd: 202[4](https://github.com/canonical/netplan/actions/runs/8265397396/job/22610944314#step:5:5)-03-13 13:22:3[5](https://github.com/canonical/netplan/actions/runs/8265397396/job/22610944314#step:5:6) Found /home/runner/work/netplan/netplan/spread.yaml. 2024-03-13...

> Also, will netplan currently write a separate private config for the sensitive parts? If so, I think it's worth a separate integration test ensuring the pieces get written correctly....

See also: https://bugs.launchpad.net/ubuntu/+source/liburi-perl/+bug/1981608 And: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014720

@rkratky May I ask you to take a look at this?

> Currently, two checks are failing, but they're not documentation checks and I didn't touch the code base, so I'm assuming it's safe for me to ignore them. The "Run...

Rebased, should now be ready for merging. Thanks again for your contribution to Netplan @ade555 !

Sorry, this is taking much longer than anticipated. I like the idea of having `pciid` matching capabilities. But it touches core components of Netplan and I need to find enough...

> alfonsosanchezbeato: to be clear, the networkctl reload/reconfigure commands seem to work, but after 6-8 minutes the state goes back to the one expressed by the old .network files >...

Just a note (not a full review, yet): We need to double check if this still works for LP#1669564 (https://github.com/canonical/netplan/commit/f4b0c54243539a9424d0f5987f1ee9e2288a529e)

This is going backwards wrt. https://github.com/canonical/netplan/pull/200