Town-Of-Us
Town-Of-Us copied to clipboard
refactor: better ability handling
This PR aims to better the handling for the role ability buttons
Full list of changes:
- Ability buttons now enable/disable with the HUD (eg, when opening the map the button is hidden, before the button would stay active)
- Whenever a target is selected for a role's ability, the target gets an outline the same color as the role, so a Sheriff has a yellow target outline
- Ability buttons cooldown only goes down while the player is not in a menu (same as impostor cooldown)
- However, it still goes down with a task open, I have had feedback about this change and the majority prefer roles like sheriff to not have a reason to not do their tasks
- Fixes any existing issues with the Altruist revive
- Better vote handling
- This also fixes the issue with all clients seeing a tie instead of a skip
- If the Time Lord walks up to vitals, with the time lord can use vitals setting off, the use button doesn't highlight (previously the vitals screen would open and close immiedietly)
- Removed
FixLights
RPC call in favour of theEngineerFix
RPC call - Removed
ExecutionerToJester
RPC call in favour of a localPlayerControl.Die
patch - Changed the internals of how the Shifter works
- No longer needs to be updated it more Impostor roles are added (lol)
- Morphling and Glitch morph/mimic abilities are now disabled if camo is active
- The hack ability no longer breaks a shield
- The Glitch's Mimic menu now has an exit button (#176)
- Refactored the internals of the hack ability (#250)
- The Miner can no longer place vents in under the map positions
- The miner vents can be placed in un-usable positions, but
- Janitor, Undertaker and Altruist can no longer be used through walls
- The check and X mark when voting now slide in for the mayor
- Adds new Button Barry button sprite (provided by @dumbplayer2)
- Fixed the mayor vote buttons not sliding in
- Updated to 2021.6.30
- Removes skip vote text from mayor abstain button
- Removes kill text on all ability buttons
NEW BUGS INTRODUCED BY 2.2.0 FIXED BY THIS PR:
- Swapper can actually get button barry (see here)
- The correct kill sprite is used for sheriff/glitch kill buttons
- The glitch can now have button barry, but the button is moved
Status: PR is ready, may need some tweaking but other than that its ready
~~PR is ready~~, just needs some more testing before being merged, no doubt with a PR this size theres probably an issue i didn't come across while making
on second thoughts, converting back to a draft for the moment
converting to draft as more issue(s) need to be addressed