Son Luong Ngoc
Son Luong Ngoc
I think the downside of that approach is that in-progress executions will not have a label attached to them, which will make it hard to filter them on our UI?...
I rebased this on top of the latest origin/master today and resolved the conflicts. So to confirm, the direction we wana go with this PR is: - Remove mnemonic +...
It seems like most of the relevant metadata has already been added to ExecutionTask.RequestMetadata. Our Executor would pick it up and attach it back to `publish.Operation` rpc https://github.com/buildbuddy-io/buildbuddy/blob/c7c2a7681c6f2424f75bc8c1e43cc55ceaba4e15/enterprise/server/scheduling/priority_task_scheduler/priority_task_scheduler.go#L336-L341 So the...
``` 998c681b70a2 :) select target_label from buildbuddy_local.Executions; SELECT target_label FROM buildbuddy_local.Executions Query id: d0ae7edd-abd6-42e8-9fc0-2e316b30abaf ┌─target_label─┐ 1. │ //:a │ └──────────────┘ ┌─target_label─┐ 2. │ //:a │ └──────────────┘ ┌─target_label─┐ 3. │ //:a...
Local config to test ``` --- a/enterprise/config/buildbuddy.local.yaml +++ b/enterprise/config/buildbuddy.local.yaml @@ -8,10 +8,11 @@ app: user_owned_keys_enabled: true streaming_http_enabled: true invocation_log_streaming_enabled: true + enable_write_executions_to_olap_db: true database: data_source: "sqlite3:///tmp/${USER}-buildbuddy-enterprise.db" -#olap_database: -#data_source: "clickhouse://default:@127.0.0.1:9000/buildbuddy_local" +olap_database:...
Added a small UI change to render the target label in the Executions tab as well. The position is consistent with the current label in the Spawns tab. 
The existing test is more like a unit test running on top of sqlite. To properly test this, I would need to turn it into a firecracker test (need firecracker+dockerd)...
Thanks everyone 🤞
@ivucica thanks for replying! It's possible to checkout `git submodule` in our Workflows offering today, but you would have to create a `sh_binary` that calls `git submodule update --init` and...
I don't think there is a use case for a "workspace-level" config like that. We should simply follow the WORKSPACE detection logic of Bazelisk https://github.com/bazelbuild/bazelisk/blob/24651abd7c833829b585373cd540a30cd98e7dfd/ws/ws.go#L9-L34 Once Bazelisk has downloaded the...