Jffarge
Jffarge
> > Nx had an update that changed some things including adding vite, which I would love to try and which would make it lots easier to actually get around...
@benjaminstrasser ! feel free to reopen this PR if needed. Thanks
> It is fitting that all test just passed and that the CLI integration is done 🎉 @gerhard Test engine is failing.
> So the generated code looks good to me > > Mage file looks good to me > > Code LGTM > > The only remaining nit are the extra...
LGTM 🚀 ! every tests passed
Close this one as done
@benjaminstrasser nice timing ;). I've worked on it today. I can add you as a reviewer if you want ?
@helderco could we close this one ?
Closing this issue as fixed. @marcindulak Feel free to reopen it if needed. Thanks
> `sdk/nodejs/.eslintrc.cjs` explicitly ignores `api/types.ts`. Both Python and Go produces valid linted code, NodeJS should do the same. > > /cc @slumbering @TomChv @dolanor `types.ts` file is not used anymore....