lackluster.nvim icon indicating copy to clipboard operation
lackluster.nvim copied to clipboard

fix optional `nvim-web-devicons` setup doc

Open k14lb3 opened this issue 1 year ago • 2 comments

Checklist

  • [x] I read the CONTRIBUTING GUIDE
  • [ ] I opened a CONTRIBUTING ISSUE before opening the PR

Description

The existing sample nvim-web-devicons setup doc advises to do:

image

Since we're overriding the default_icon to override the colors of the icons, not putting the default_icon.icon removes the icon for the default_icon.

Screenshots

Before After
image image

k14lb3 avatar Oct 13 '24 17:10 k14lb3

Thanks for the PR!

I'm busy doing some family stuff for the next week or two and am AFK so It might be a while to test and review this.

In the meantime can you explain with more details what problem this solves? I don't really understand your PR message.

Also is it possible to include a before and after screenshot?

slugbyte avatar Oct 14 '24 05:10 slugbyte

@slugbyte I updated the PR description. Thanks.

k14lb3 avatar Oct 14 '24 05:10 k14lb3

Thanks for the update! I still am AFK but I have been thinking about this issue a bit and want to make the icon nil by default, but allow users to set the default icon using the lackluster.setup func. I haven't decided how exactly I would want this implemented yet though. This is because I personally prefer no icon over having a default icon, but I'm willing to support users choosing their own icons :) I hopefully will be able to get to this sometime next week :)

Sorry for the delay!

slugbyte avatar Oct 17 '24 05:10 slugbyte

This is because I personally prefer no icon over having a default icon

Oh, I see. So it was intentional. I guess I'll close the PR then.

k14lb3 avatar Oct 17 '24 11:10 k14lb3