slskd icon indicating copy to clipboard operation
slskd copied to clipboard

Transfer size column is too narrow

Open jpdillingham opened this issue 2 years ago • 5 comments

image

I thought I tested this with some worst-case-scenario values, but I guess not. I believe something like 1000.00 Bytes/1000.00 Bytes would be the longest possible value here.

This is taking up quite a bit of real estate on the screen and I'm questioning whether it is worthwhile to display both the bytes downloaded and size, especially when the objectively more interesting transfer speed isn't present at all.

I'm not sure what to do here exactly, but these values shouldn't be able to wrap.

jpdillingham avatar Jun 09 '22 14:06 jpdillingham

You could truncate bytes and kilobytes by removing one or both decimals.

camm9909 avatar Jul 01 '22 22:07 camm9909

Would it be fine if I work on this?

skar07 avatar Oct 15 '22 09:10 skar07

@skar07 sure thing!

I think the ideal solution is to make sure the suffix only appears once, so 1.38 KB/1.38 KB would appear as 1.38/1.38 KB. I'm not sure why some sizes do this and KB and Bytes don't. It's probably something pretty simple.

jpdillingham avatar Oct 15 '22 13:10 jpdillingham

Hi I'm looking to contribute and think I've got a solution, let me know what you think.

Bytes should be removed and replaced with the short-form B. Then we should only use one decimal place for both the size and transfer numbers. Finally the transfer number should always match whatever unit is displayed for the size so that it doesn't have to display two units at any time. example: (100 KB/100 MB) would be (0.1/100MB)

If you think this will work I can get a PR out shortly.

paverett avatar Sep 26 '23 03:09 paverett

@paverett sounds great! I'll assign it to you.

jpdillingham avatar Sep 26 '23 23:09 jpdillingham