slsa icon indicating copy to clipboard operation
slsa copied to clipboard

Published 20 hours ago • verified publisher icon slsa-framework

Add label to guest blog posts

Open lehors opened this issue 2 years ago • 5 comments

This change adds the label "Guest Post" to the author line of guest blog posts, both to the post itself and the blog page.

Signed-off-by: Arnaud J Le Hors [email protected]

lehors avatar Sep 30 '22 13:09 lehors

Deploy Preview for slsa ready!

Name Link
Latest commit 004f641b14e7977913fb88a5256af2896c33c3ca
Latest deploy log https://app.netlify.com/sites/slsa/deploys/6337154c37601f00084836a1
Deploy Preview https://deploy-preview-495--slsa.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 30 '22 13:09 netlify[bot]

I know there has been some discussion about labeling the blog posts and a footer has been added to blog posts by guests but I think this change makes it clearer what is what without being overly intrusive. In particular this doesn't label non-guest posts as "Official" or anything like that. I think that's unnecessary.

lehors avatar Sep 30 '22 13:09 lehors

I think this is fair to include. The question I have is: when is a post not a guest post? I think we have talked about that before but it would be good to have that clearly defined.

abacchi avatar Sep 30 '22 13:09 abacchi

I think this is fair to include. The question I have is: when is a post not a guest post? I think we have talked about that before but it would be good to have that clearly defined.

I think this has been done:

  1. The governance docs introduce the two types of posts: See sections 1.1.1.4. Blog Posts and 4.6 Blog Post Specific in https://github.com/slsa-framework/governance/blob/main/6._Contributing.md

  2. The blog posts source files do carry a boolean flag "is_guest_post"

  3. issue #309 also provides some additional info.

lehors avatar Sep 30 '22 14:09 lehors

Thanks @lehors; yes I would prefer this to be more visible, but we also need to make sure we have due diligence to make OFFICIAL posts not marked as guest. (There was one marked as guest post recently that was a community post)

melba-lopez avatar Sep 30 '22 14:09 melba-lopez

Oops, I wish GitHub reminded us about pull requests that are ready to merge. Merging now!

MarkLodato avatar Oct 14 '22 14:10 MarkLodato

Oops, I wish GitHub reminded us about pull requests that are ready to merge. Merging now!

I think you can set Auto-merge on simple ones ?

inferno-chromium avatar Oct 14 '22 14:10 inferno-chromium