slsa-verifier icon indicating copy to clipboard operation
slsa-verifier copied to clipboard

Re-visit GetWorkflowInputs()

Open laurentsimon opened this issue 1 year ago • 1 comments

We use this function to match the inputs to a workflow https://github.com/slsa-framework/slsa-verifier/blob/main/verifiers/internal/gha/slsaprovenance/common.go#L12.

We seem to always look at the trigger workflow's input. We may want to change this for our own builders, since our builders using v1.0 specs have a different interface: we should match on the re-usable workflow inputs rather than the trigger workflow's inputs for v1.0 specs.

laurentsimon avatar Apr 20 '23 22:04 laurentsimon

We may also rename this to externalParameters, to be consistent with v1.0

laurentsimon avatar May 22 '23 18:05 laurentsimon