slsa-github-generator icon indicating copy to clipboard operation
slsa-github-generator copied to clipboard

feat: upload provenance to release via a `tag-name`

Open laurentsimon opened this issue 3 years ago • 2 comments
trafficstars

See https://github.com/slsa-framework/slsa-github-generator/issues/710

laurentsimon avatar Aug 13 '22 00:08 laurentsimon

@ianlewis yamlling seems to be failing. Does

Successfully installed pathspec-0.10.1 yamllint-1.26.3
Error: [trailing-spaces] trailing spaces

means it found a problem with a yaml file? Or is it failing itself?

laurentsimon avatar Sep 20 '22 23:09 laurentsimon

@ianlewis yamlling seems to be failing. Does

Successfully installed pathspec-0.10.1 yamllint-1.26.3
Error: [trailing-spaces] trailing spaces

means it found a problem with a yaml file? Or is it failing itself?

The error shows up in the PR diff view. I don't think the output shows up in the log very well for some reason. It seems to omit the file name and line number. https://github.com/slsa-framework/slsa-github-generator/pull/713/files#diff-a526f8e747aef206fec2ce8469bbc904ee1a8d047bbb486743cca4e2dd5e5037R175

ianlewis avatar Sep 21 '22 04:09 ianlewis

ping -- does this need another review after a merge?

asraa avatar Nov 02 '22 15:11 asraa

Let me get back to this PR when I'm back. It's been a while so I need to look into it. Thanks for pinging!

laurentsimon avatar Nov 02 '22 21:11 laurentsimon