example-package icon indicating copy to clipboard operation
example-package copied to clipboard

Published 20 hours ago • verified publisher icon slsa-framework

[test] fix gcb e2e

Open ramonpetgrave64 opened this issue 10 months ago • 1 comments

Followup to https://github.com/slsa-framework/example-package/pull/350

Fixes the tests to correctly edit the payload file, so that this particular test fill fail as expected.

  • https://github.com/slsa-framework/example-package/blob/e60c8d2444ef0e946b6dcf29528ef444b9d2e7fc/.github/workflows/scripts/e2e-verify.common.sh#L540

We may also want to do the same change on the next line, for non-gcb tests

  • https://github.com/slsa-framework/example-package/blob/e60c8d2444ef0e946b6dcf29528ef444b9d2e7fc/.github/workflows/scripts/e2e-verify.common.sh#L197-L198

Testing

executed the workflow against this PR's branch

https://github.com/slsa-framework/example-package/actions/runs/8756899306/job/24034397658#step:5:150

...
  **** Wrong payload *****
WARNING: Insecure SLSA_VERIFIER_TESTING is enabled.
FAILED: SLSA verification failed: invalid DSSE envelope payload: unexpected end of JSON input
...

ramonpetgrave64 avatar Apr 19 '24 15:04 ramonpetgrave64

@laurentsimon

ramonpetgrave64 avatar Apr 24 '24 20:04 ramonpetgrave64

@haydentherapper @laurentsimon

ramonpetgrave64 avatar Jul 23 '24 22:07 ramonpetgrave64