S.Lott

Results 43 comments of S.Lott

Technically, `None` is raw Python. This isn't exactly the same thing has a CEL `NullType` instance. We could raise a better exception for "raw" Python objects. We could try to...

Yes. Seen https://github.com/cloud-custodian/cel-python/blob/main/src/celpy/__init__.py which has a `functions = {}`. This is the mapping from a CEL-visible name to a Python function.

"based on the code I have already written" Intriguing. Please share more. A pull request would be a very helpful way to clarify your intent.

There was no design intention to be thread-safe. There are no internal threads. An example of using `threading.local()` to manage storage for an Environment instance would be helpful. If a...

It's not perfectly clear (to me) what the benchmark Go implementation does in this case. I'm unclear on where the Go implementation does type-checking.

A pull request to replace re with https://pypi.org/project/re2/ would be welcome.

There's a tox.ini to run a complete test suite. The style is generally done by black. You can also look at the GitHub workflows to see how the tox.ini runs.

See https://github.com/cloud-custodian/cel-python/pull/63 which fixes this problem.

Yes. Seen https://github.com/cloud-custodian/cel-python/blob/main/src/celpy/__init__.py which has a `functions = {}`. This is the mapping from a CEL-visible name to a Python function.

This does seem wrong to ignore an actual timezone and treat it as UTC ("Z")