slothy icon indicating copy to clipboard operation
slothy copied to clipboard

Disable address fixup by default

Open mkannwischer opened this issue 1 year ago • 1 comments

The address fixup as currently implemented sometimes breaks code if registers which are used for addresses are used in any other instruction than load and stores.

#95 added an option unsafe_address_offset_fixup to control if address fixup is enabled or not. Currently it is enabled by default, but that is dangerous and should be changed. However, that requires to changes a lot of examples

See

        # TODO: This should be False by default, but this is a breaking
        # change that requires a lot of examples (where it _is_ safe to
        # apply address offset fixup) to be changed.
        self._unsafe_address_offset_fixup = True

mkannwischer avatar Nov 06 '24 08:11 mkannwischer

Since #255 got merged, nothing is stopping us from making this change. Should be disable it by default now? How do we identify the examples that make use of offset fixup?

mkannwischer avatar Aug 13 '25 07:08 mkannwischer