Steven Loria comments

Results 329 comments of


                                            Steven Loria

Simplify field overrides

As an intermediate step, we could set more defaults at the class level ```python fields.Field.default_required = True ```

I suspect a breaking change related to "include_relationships=True" and schema.load() in version 1.4.1

I wasn't able to reproduce this. added a test to cover this case in https://github.com/marshmallow-code/marshmallow-sqlalchemy/pull/666 and it passes. @Curiouspaul1 can you post a more complete minimal reproducible example?

I suspect a breaking change related to "include_relationships=True" and schema.load() in version 1.4.1

sorry--haven't had much time to work on marshmallow these days. would definitely appreciate help on this, even if it's an incomplete PR.

Suggestion: Refactor builtin fields to expose validators for re-use

Seems like a reasonable change to me. We'd certainly review a PR, @bjmc !

Type hinting for `load` is too strict

Ah, right, the typing isn't completely correct. PRs welcome!

Type hinting for `load` is too strict

https://github.com/marshmallow-code/marshmallow/pull/1488 fixes this.

Type hinting for `load` is too strict

Is there a way to make it work when `many=None`, i.e. when `self.many` is used?

Type hinting for `load` is too strict

@jtrakk Would you like to investigate this further and send a PR to improve the typing? I'm afraid I won't be able to look into this within the next few...

fields.Nested should optionally pass the parent object to the Nested Schema

I'm not opposed to the idea. Feel free to send a PR for review. However, I can't promise we'll get to it in the immediate future because we're currently focused...

fields.Nested should optionally pass the parent object to the Nested Schema

@timc13 That's a good point. @remeika Is your use case solved by using a computed property like in Tim's example?