Steven Loria

Results 239 comments of Steven Loria

FYI: marshmallow v3 (stable) has been released. Along with the aforementioned API improvements, serialization performance is significantly better than v2. There's an upgrading guide here: https://marshmallow.readthedocs.io/en/stable/upgrading.html . Please don't hesitate...

We are currently working around this by setting `error_collector.expected_classes` instead, which does work as expected.

@umaannamalai Oh sorry, you're right--my screenshot is misleading. in any case, the setting did not have the expected effect. > Are you finding that the agent is still factoring the...

Oh I see, that's the issue--we're using a framework that re-raises `werkzeug.exceptions.HTTPExceptions` with a custom error, so we won't hit that code. perhaps the issue could be solved with some...

local-repl doesn't do any transformations (other than `await` syntax if `enableAwait` is enabled), so it will support the same syntax as the version of Node you're using. I'm unsure of...

Hm, we could do what DRF does and allow either a `schema_class` class variable or a `get_schema_instance` method to be defined. `flask.g` could work, though I'd worry if there are...

@itajaja If you need a separate context per-instance, then `flask.g` could be problematic. That said, I guess you could work around this by setting `flask.g` in `pre_load` and then resetting...

Yeah, marshmallow and WTForms mutate field objects upon instantiation (marshmallow via a `Field #_bind_to_schema(field_name, schema)` hook). Using classes would be better. Perhaps deprecate `authorization` in favor of `authorization_class` (or `authorization_classes`...

Yeah, I like the inlining idea in principle. Certainly a big change, though could be done iteratively. Also, `views.py` could get pretty huge...we might eventually want have a module per...

Here's a run with the mypy defaults ```diff diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3d8d20d..8461356 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -8,6 +8,10 @@ repos: rev: v0.4.3 hooks: - id: fourmat...