Sébastien Lorber

Results 1471 comments of Sébastien Lorber

👍 yes that's also my conclusion. A JS polyfill is not too bad UX though :)

Same here, trying to upgrade an app from Expo SDK 40 to 41. An error in devtools related to source maps: http://localhost:19000/debugger-ui/debuggerWorker.aca173c4.js.map ![image](https://user-images.githubusercontent.com/749374/116445581-57e1c600-a856-11eb-9161-8f5e96a0c426.png) ![image](https://user-images.githubusercontent.com/749374/116445658-67610f00-a856-11eb-85d6-39327a8934fe.png) This is just annoying to have...

@camdagr8 what you want can also be done by using babel macros / codegen https://medium.com/@karanjthakkar/using-babel-macros-with-react-native-8615aaf5b7df @jeanlauliac I have an app which is actually 2-in-1 apps. It's like a merge of...

Thanks @jeanlauliac , require() will be fine for me then, as I don't need to download remote js code, and require is enough for all local code (many usecases can...

It's not totally related, but wanted to mention here that optional requires are now possible. Not sure how but this might enable a workaround for some people interested by this...

I'd like to add that require cycle may be intentional inside your app code and is fine in many cases if you know what you are doing and don't start...

**EDIT: DON'T DO THIS, ITS INSECURE** (https://github.com/preactjs/compressed-size-action/issues/54#issuecomment-789661178) --- ~~A workaround is to force the checkout on pull request head sha with `actions/checkout@v2` before this action runs~~ ``` jobs: report-build-size-diff: runs-on:...

After discussing with security at Github and Facebook, my workaround works but is **insecure** and can lead to the GH token being stolen. https://securitylab.github.com/research/github-actions-preventing-pwn-requests When using `pull_request_target`, you should NEVER...

@developit git commit statuses work great for some use-cases but the maintainer would have to check it to see potential size regressions, which will likely remain unseen in many cases....

Yes that should work, also what I suggested by using 2 actions above. FYI we are using this action to post a lighthouse comment, so it can probably be re-used,...