Sébastien Lorber
Sébastien Lorber
I'll do that on Thursday when I'm back on Docusaurus 👍 Yes, it's additional manual work for me because Argos CI is not installed on this repo and I have...
> I guess our primary use cases would be significant version bumps like this one. We rarely do site-wide changes that are hard to check if regressing from a preview...
Thanks I think it would be better to open a RFC and once we agree on what should be done, open a new PR. For now I'm closing this one
> react 19 have built-in support for metadata tags, see [react.dev/blog/2024/12/05/react-19#support-for-metadata-tags](https://react.dev/blog/2024/12/05/react-19#support-for-metadata-tags) This package is not needed anymore that's not 100% true  If you rely...
If anyone finds it helpful, Docusaurus is now running on my v1.3.0 fork, which allows React 19 as peerDeps: `"react-helmet-async": "npm:@slorber/[email protected]",`. No problem so far. I didn't fork from v2...
TIL that the UnJS ecosystem has a new `@unhead/react` package 🥳 thanks @harlan-zw https://unhead.unjs.io/docs/react/head/guides/get-started/installation From the PR: https://github.com/unjs/unhead/pull/477 > It can directly replace [react-helmet](https://github.com/nfl/react-helmet?rgh-link-date=2025-02-04T14%3A14%3A36Z), handling a more diverse set of...
@birdofpreyru, having multiple options is fine. I don't really see the point of 👎 my comment. Personally, I like to adopt libs under the UnJS organization, which are generally well-maintained...
Someone else also invested time/money, before you, to provide React-Helmet compatibility: - https://github.com/unjs/unhead/pull/477 - https://unhead.unjs.io/docs/react/head/guides/get-started/migrate-from-react-helmet I don't want to dismiss your work, but it's not fair to reject other possible...
Yes, it makes sense to me to not have this extra `-30px` 👍 Not so satisfied with all our layouts in general, probably need to refactor all this a bit...
Some of those layout issues are quite historical, and changing these can mess-up with existing customized sites so I'm always a bit frightened to do these changes. We'll probably need...