Sébastien Lorber

Results 1353 comments of Sébastien Lorber

@alirezamirian that looks like a reasonable suggestion. I've implemented it here with a secret env variable to opt-out just in case it cause troubles to our users for unexpected reasons:...

Note we also need to alias `@mdx-js/react` because MDX will eventually add an extra import depending on the MDX content to import components from React context. ```js import {useMDXComponents as...

Agee there is something wrong happening here If the icon is smaller, it should stay aligned Apparently it's not the case: ![CleanShot 2024-07-10 at 15 07 20](https://github.com/facebook/docusaurus/assets/749374/d29663ea-c098-4266-941c-7dd96ca23c53) Note: we had...

Left my initial review here: https://github.com/facebook/docusaurus/pull/10354#pullrequestreview-2207965245 To be honest, although the proposed solution might fix the problem, and we might still want to limit git concurrency, I believe it only...

I'm not 100% sure but it seems "EBADF" means "Error, bad file descriptor" in Node.js I propose that we first remove shelljs and see if the problem disappears by testing...

> > I'm not 100% sure but it seems "EBADF" means "Error, bad file descriptor" in Node.js > > I propose that we first remove shelljs and see if the...

We have replaced shelljs by execa in https://github.com/facebook/docusaurus/pull/10358 Please test in canary and the upcoming v3.8, and let us know if this works better. Unfortunately it seems only you can...

I was able to reproduce the issue on another large Docusaurus site, even with execa: https://github.com/sailpoint-oss/developer.sailpoint.com See also https://github.com/facebook/docusaurus/discussions/11140 ``` [ERROR] Error: Unable to build website for locale en. at...

@robert-j-webb I agree that we could support reading from both `.json` and `.js` for versioned sidebars. --- Just wanted to explain the reason why we historically only support `.json` so...

I think it's preferable if I implement this myself because I'm not sure how it should be done. In any case, we'd want to avoid sync IOs like this. We...