sloth icon indicating copy to clipboard operation
sloth copied to clipboard

Recording rules duplicates check

Open r3code opened this issue 2 years ago • 3 comments

I've noticed that if I pass a folder to sloth validate it allows SLO duplicates to exist.

When creating a new SLO sometemes I copy spec from existing specs and forgot to change names. Sloth perfectly validates and generates rules in such cases. But it can lead to duplicates of recording rules, and unpredictable behaviour durind recording.

We can deploy rules as prom, k8s, and openslo. Prom and K8S are almost the same and have equal slo_id format <service>-<slo.name>, but OpenSLO uses slightly different <service>-<slo.name>-<seq_no>.

So it looks like better not to mix spec types for the same service. But if I have a folder with specs of one type, e.g. Prom specs for CLI generation, I want to know about slo duplicates in a folder or multifile yml.

r3code avatar Apr 04 '23 16:04 r3code

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Mar 29 '25 02:03 github-actions[bot]

This issue was closed because it has been stale for 15 days with no activity.

github-actions[bot] avatar Apr 14 '25 02:04 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Jun 16 '25 02:06 github-actions[bot]

This issue was closed because it has been stale for 15 days with no activity.

github-actions[bot] avatar Jul 01 '25 02:07 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

github-actions[bot] avatar Sep 01 '25 02:09 github-actions[bot]

This issue was closed because it has been stale for 15 days with no activity.

github-actions[bot] avatar Sep 17 '25 02:09 github-actions[bot]