sloth icon indicating copy to clipboard operation
sloth copied to clipboard

Published 20 hours ago • verified publisher icon slok

Missing CPU Limit in Helm template

Open druanoor opened this issue 2 years ago • 1 comments

Hi.

CPU Limit is missing in the helm template, i opened a PR to fix this issue: https://github.com/slok/sloth/pull/351

druanoor avatar Jul 18 '22 13:07 druanoor

Also this PR from another user is moving resources values to values.yaml file: https://github.com/slok/sloth/pull/324

druanoor avatar Jul 18 '22 13:07 druanoor

@slok , can you review and merge these PRs, please?

evgkrsk avatar Oct 18 '22 10:10 evgkrsk

The CPU limits were removed on purpose (1, 2, ), CPU limits cause more harm than good. However, we are moving the resources to the values.yaml so anyone can put whatever want.

slok avatar Oct 22 '22 10:10 slok

Fixed in #324

slok avatar Oct 22 '22 10:10 slok