slipher

Results 866 comments of slipher

As I said it's the `-DDEPS_DIR=${DEPS_DIR}` flag to the child cmake invocation in DaemonGame.cmake. It stopped working because you started to always write the value of DEPS_DIR, instead of leaving...

The nacl patch could have gone into its own commit if you put the Python cmake changes into the squashed commit, since I made it work with Python 2. LGTM

I mean the stuff that looks for Python 2/3 instead of Python 2 needs to be in (or after) the big commit.

The commit for enabling Python 3 says that I am the author which is not right. Otherwise LGTM

The default color can be specified in the `Color::Parser` constructor. The alpha trick is only needed if you have a special use case where you want to behave differently from...

I looked at the uses of server commands and some of them might be relevant in the loading stage, namely where the client is kicked / the server shuts down.

According to my previous comment I was unable to reproduce this

> I confirmed the backtrace proves something wrong is going on with CBSE: here's when a human has been killed by the juggernaut (LEVEL3_UPG). There is no dretch, yet CBSE...

I think I found it. We have this call chain `G_PlayerDie -> G_AddCreditsToScore [or AddMomentumToScore] -> AddScoreHelper -> CalculateRanks ->CheckExitRules -> BeginIntermission`. This means BeginIntermission, which fucks with entities, may...