run-wasm icon indicating copy to clipboard operation
run-wasm copied to clipboard

Rename the example-nextjs -> website

Open jsjoeio opened this issue 2 years ago • 7 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I think the example-nextjs folder could be named more appropriately.

Describe the solution you'd like A clear and concise description of what you want to happen.

Rename to website

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Additional context Add any other context or screenshots about the feature request here.

N/A

jsjoeio avatar Oct 02 '21 18:10 jsjoeio

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I think the example-nextjs folder could be named more appropriately.

Describe the solution you'd like A clear and concise description of what you want to happen.

Rename to website

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Additional context Add any other context or screenshots about the feature request here.

N/A

can with-nextjs be a good example?

have seen this pattern in bunch of repos

Screenshot 2021-10-03 at 10 02 43 AM

Deep-Codes avatar Oct 03 '21 04:10 Deep-Codes

If the suggested approach in the PR subscription looks good then I can go ahead and work on it.

shadab14meb346 avatar Oct 03 '21 16:10 shadab14meb346

@Deep-Codes Hmm...I mean this folder is specifically for the runwasm website. the "with-nextjs" is a common pattern when you explaining how to use X with Y,Z tools.

I don't think that would fit in this case.

If the suggested approach in the PR subscription looks good then I can go ahead and work on it.

I think we'll need to wait for @kennethcassel to chime in here!

jsjoeio avatar Oct 04 '21 16:10 jsjoeio

@jsjoeio yeah we should rename it website!

kennethcassel avatar Oct 20 '21 19:10 kennethcassel

@shadab14meb346 feel free to take this on (or if you don't want to do this, tell me and I will!)

jsjoeio avatar Oct 27 '21 21:10 jsjoeio

Hi @jsjoeio yeah you can go ahead and do it. I see for me a lot of lint issues are coming some how.

shadab14meb346 avatar Oct 29 '21 13:10 shadab14meb346

Not sure if/when I'll get to this so someone else can hop in if they want :)

jsjoeio avatar Nov 02 '21 18:11 jsjoeio