slint
slint copied to clipboard
add VecModel::extend_from_slice
closes #1647
Thanks for the PR!
Since the same method in Vec is called extend_from_slice
I believe it should be called the same here.
Or it should take an Iterator instead of a slice, like the extend method in vec.
Since the same method in Vec is called
extend_from_slice
I believe it should be called the same here.
@ogoffart Renamed it 👍
Thanks, that's perfect.
In order to be complete, we should also have a test (maybe similar or as an extension to test_vecmodel_set_vec
) , and a change log entry. Perhaps the documentation could say it is similar to Vec::extend_from_slice, with a link to the Vec's documentation.
@idipot Would you be up for adding a test and a changelog entry? No problem if you're busy, then I can also do that :)
@idipot Would you be up for adding a test and a changelog entry? No problem if you're busy, then I can also do that :)
Hi, i was on vacation. I'll add a test and the changelog entry 👍
Thanks for your contribution. I'm just merging this and I'll write the test in a followup commit.