Updating examples

[thonic]

Hi, I just wanted to ask which parts of the examples "need to be updated":

def demo(seed=None):
    """
    Create a discrete time Hawkes model and generate from it.
    :return:
    """
raise NotImplementedError("This example needs to be updated.")

from

/examples/inference/standard_bfgs_demo.py

and other files.

Thanks in advance.

[slinderman]

Hi @thonic, thanks for reminding me about this. I changed the constructor signature last year and I never got around to backporting it to the BFGS/GD/SGD examples. It only required some minor changes to get bfgs back up and running. Unfortunately, this demo is still not as nice as the discrete and continuous demos in the examples directory.

See https://github.com/slinderman/pyhawkes/commit/279fbb4f034356c651614a8f67d94c9489e7758a

I'll leave this open until I can clean up the other examples too.