shopify-api-php icon indicating copy to clipboard operation
shopify-api-php copied to clipboard

500 if no Coordinates in Orderadress?

Open karatektus opened this issue 4 years ago • 5 comments

woke up to a weird bug today, see here: image

karatektus avatar Mar 30 '20 10:03 karatektus

kay found it. see here: #66

karatektus avatar Mar 30 '20 11:03 karatektus

Hello, You seem to be using version 3.x, which is unstable; You should change minimum-stability: stable

slince avatar Mar 30 '20 12:03 slince

that was on purpose - master didn't work with symfony 5

karatektus avatar Mar 30 '20 13:03 karatektus

hello, In the 3.x , symfony/serializer was used instead of JMS /serializer; And here's a bug: https://github.com/symfony/symfony/issues/36079

Can you submit a pr to the master branch if possible?

slince avatar Mar 30 '20 13:03 slince

hi, symfony/serializer is the way forward imo anyway. A pr to master is a little complicated since i dont use it. wont you merge 3.x into master anyway?

karatektus avatar Mar 31 '20 10:03 karatektus