slim icon indicating copy to clipboard operation
slim copied to clipboard

Unable to utilize the creport.json file generated from slim profile command

Open Oh-Py-God opened this issue 1 year ago • 2 comments

Expected Behavior

Use the creport.json generated from the slim profile command as an input for the slim build. Keep only the file paths from the creport.json file


Actual Behavior

creport.json file is not picked up from the arguments


Steps to Reproduce the Problem

  1. Perform image profiling using the slim profile command and generate artifacts in a local folder. Command: slim profile --target <target_image> --env-file <env_file_path> --copy-meta-artifacts profile_artifacts
  2. Number of file_paths in profile_artifacts/creport.json file = 44
  3. Use the build command with the required arguments to build a slim image. Command: slim build --image <target_image> --tag <slim_tag> --include-paths-creport-file profile_artifacts/creport.json --http-probe-off=true --copy-meta-artifacts build_artifacts --continue-after 5 --env-file <env_file>
  4. Number of file_paths in profile_artifacts/creport.json file = 5503
  5. size.original='961 MB' size.optimized='458 MB'
  6. Expected slim image size: < 20 MB can be achieved with http-probe enabled. However, as http probing was already done during profiling, I don't want to redo it.

Specifications

  • Version: slim version linux/amd64|Transformer|1.40.11|1b271555882eacdfb4e6598d6d0552e9b9b1449b|2024-02-02_01:36:22PM
  • Platform: linux x64

Oh-Py-God avatar Oct 08 '24 09:10 Oh-Py-God

The profile command needs to be refactored to utilize the build command logic because not all build command logic enhancements made it to profile. Good news it's on the roadmap and will be done 100%! Not so good news it's lower priority, so it won't happen right away :-)

kcq avatar Feb 13 '25 19:02 kcq

That would be great! @kcq . I'll check if I can contribute to the refactoring.

Oh-Py-God avatar Feb 17 '25 13:02 Oh-Py-God